Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the C++ standard to C++20; Replace gsl::span with std::span. #39

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Upgrade the C++ standard to C++20; Replace gsl::span with std::span. #39

merged 5 commits into from
Nov 29, 2023

Conversation

LinZhihao-723
Copy link
Member

Description

This PR upgrades the C++ standard from C++17 to C++20. With C++20 enabled, gsl::span can be now replaced by std::span.

kirkrodrigues
kirkrodrigues requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove the gsl submodule, right?

src/clp_ffi_py/ir/native/PyDecoderBuffer.cpp Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@LinZhihao-723
Copy link
Member Author

Didn't remove GSL since it seems useful for future changes. But sure, we can add it back when needed.

@LinZhihao-723 LinZhihao-723 merged commit 22f707d into y-scope:main Nov 29, 2023
3 checks passed
@kirkrodrigues kirkrodrigues mentioned this pull request Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinZhihao-723 @kirkrodrigues